Piotr Kliczewski has posted comments on this change. Change subject: events: VM Status based on an event ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/37488/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 897: } Line 898: } Line 899: } Line 900: Line 901: public Version getComatibilityVersion() { > typo Done Line 902: return cachedVds.getVdsGroupCompatibilityVersion(); Line 903: } Line 904: Line 905: public String getVdsHostname() { https://gerrit.ovirt.org/#/c/37488/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java: Line 96: } Line 97: Line 98: private VmInternalData fetchStats(VM dbVm, VmInternalData vdsmVm) { Line 99: // TODO change to async processing Line 100: // we do not want to block a thread here > with enough thtreads to handle incoming events, do we mind blocking here? It would be hard to find what is "enough" here. If we do not need to waste resources why to do so? Line 101: VDSReturnValue vmStats = Line 102: resourceManager.runVdsCommand( Line 103: VDSCommandType.GetVmStats, Line 104: new GetVmStatsVDSCommandParameters(manager.getCopyVds(), vdsmVm.getVmDynamic().getId())); -- To view, visit https://gerrit.ovirt.org/37488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5b35877ccd63372759ad6989280e9417c259b21 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
