Piotr Kliczewski has posted comments on this change. Change subject: events: VM Status based on an event ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/37488/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java: Line 96: } Line 97: Line 98: private VmInternalData fetchStats(VM dbVm, VmInternalData vdsmVm) { Line 99: // TODO change to async processing Line 100: // we do not want to block a thread here > note that without considerable refactoring and verification of the monitori I understand and I am impressed :). We need to explore what is the bottle neck there and try to fix it. Not sure whether it should be part of this feature. Line 101: VDSReturnValue vmStats = Line 102: resourceManager.runVdsCommand( Line 103: VDSCommandType.GetVmStats, Line 104: new GetVmStatsVDSCommandParameters(manager.getCopyVds(), vdsmVm.getVmDynamic().getId())); -- To view, visit https://gerrit.ovirt.org/37488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5b35877ccd63372759ad6989280e9417c259b21 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
