Eli Mesika has posted comments on this change. Change subject: <WIP>engine: add feature comptability check for VDS ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/39756/6/packaging/dbscripts/upgrade/03_06_1250_add_cluster_features_table.sql File packaging/dbscripts/upgrade/03_06_1250_add_cluster_features_table.sql: Line 2: -- table cluster_feature_mappings Line 3: -- Maintans the list of features required from vdsm to add the host to the specific vds_gorup Line 4: -- ---------------------------------------------------------------------- Line 5: Line 6: CREATE TABLE cluster_features > why do we need to distinguish between gluster to non-gluster features ? accept that , leave as is Line 7: ( Line 8: vds_group_id UUID NOT NULL, Line 9: feature varchar(256) NOT NULL, Line 10: is_enabled BOOLEAN, Line 14: Line 15: CREATE UNIQUE INDEX IDX_cluster_features ON cluster_features(vds_group_id, feature); Line 16: Line 17: -- Comma separated values of all the features supported by the VDSM Line 18: select fn_db_add_column('vds_dynamic', 'supported_features', 'TEXT'); > will do that. so , this should be host_features -- To view, visit https://gerrit.ovirt.org/39756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
