Sahina Bose has posted comments on this change. Change subject: <WIP>engine: add feature comptability check for VDS ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/39756/6/packaging/dbscripts/upgrade/03_06_1250_add_cluster_features_table.sql File packaging/dbscripts/upgrade/03_06_1250_add_cluster_features_table.sql: Line 6: CREATE TABLE cluster_features Line 7: ( Line 8: vds_group_id UUID NOT NULL, Line 9: feature varchar(256) NOT NULL, Line 10: is_enabled BOOLEAN, > So there will be a table that will contain all the features supported by a The background for this change is to support releases made in between major compat releases. So, for instance 3.5 level supports feature A, B and C. When we introduce a feature D in a 3.5.x release, there's no way currently to distinguish a vdsm host that supports this D feature and enforce the check from engine. Hence the supported feature matrix. When we move to the higher cluster level - feature D would be available (say in 3.6) The intention was not to enumerate all features of a release/cluster level, but to check for additional features supported. Line 11: CONSTRAINT PK_cluster_features PRIMARY KEY (vds_group_id, feature), Line 12: FOREIGN KEY (vds_group_id) REFERENCES vds_groups(vds_group_id) ON DELETE CASCADE Line 13: ) ; Line 14: -- To view, visit https://gerrit.ovirt.org/39756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
