Eli Mesika has posted comments on this change. Change subject: <WIP>engine: add feature comptability check for VDS ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/39756/6/packaging/dbscripts/cluster_features_sp.sql File packaging/dbscripts/cluster_features_sp.sql: Line 1: /* ---------------------------------------------------------------- Line 2: Stored procedures for database operations on Cluster Features Line 3: related table: cluster_features Line 4: ----------------------------------------------------------------*/ Line 5: Create or replace function InsertClusterFeature(v_vds_group_id UUID, Please remove 4 spaces alignment instead of tabs Line 6: v_feature VARCHAR(256), Line 7: v_is_enabled BOOLEAN) Line 8: RETURNS VOID Line 9: AS $procedure$ https://gerrit.ovirt.org/#/c/39756/6/packaging/dbscripts/upgrade/03_06_1250_add_cluster_features_table.sql File packaging/dbscripts/upgrade/03_06_1250_add_cluster_features_table.sql: Line 14: Line 15: CREATE UNIQUE INDEX IDX_cluster_features ON cluster_features(vds_group_id, feature); Line 16: Line 17: -- Comma separated values of all the features supported by the VDSM Line 18: select fn_db_add_column('vds_dynamic', 'supported_features', 'TEXT'); > this is already a host table (vds_dynamic) so don't think we should repeat should be the same as cluster_features , no more comma-separated values for such things .... -- To view, visit https://gerrit.ovirt.org/39756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
