Alona Kaplan has posted comments on this change. Change subject: engine: Add NetworkAttachment dao ......................................................................
Patch Set 23: (1 comment) https://gerrit.ovirt.org/#/c/32581/23/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDaoTest.java: Line 127: } Line 128: Line 129: private void assertNetworkAttachmentEquals(NetworkAttachment expected, NetworkAttachment actual) { Line 130: assertEquals(expected.getId(), actual.getId()); Line 131: assertEquals(NetworkBootProtocol.DHCP, actual.getIpConfiguration().getBootProtocol()); This is redundant since now you have assertEquals(expected.getIpConfiguration(), actual.getIpConfiguration()); Line 132: assertEquals(expected.getNetworkId(), actual.getNetworkId()); Line 133: assertEquals(expected.getNicId(), actual.getNicId()); Line 134: assertEquals(expected.getNicName(), actual.getNicName()); Line 135: assertEquals(expected.getIpConfiguration(), actual.getIpConfiguration()); -- To view, visit https://gerrit.ovirt.org/32581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84187f3900b9e3f8a917fc4e4126de9e50e231b4 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
