Martin Mucha has posted comments on this change. Change subject: engine: Add NetworkAttachment dao ......................................................................
Patch Set 19: (1 comment) https://gerrit.ovirt.org/#/c/32581/19/packaging/dbscripts/upgrade/03_06_1170_add_network_attachment.sql File packaging/dbscripts/upgrade/03_06_1170_add_network_attachment.sql: Line 12: gateway CHARACTER VARYING(20), Line 13: custom_properties TEXT, Line 14: _create_date TIMESTAMP WITH TIME ZONE DEFAULT ('now'::text)::timestamp without time zone, Line 15: _update_date TIMESTAMP WITH TIME ZONE, Line 16: FOREIGN KEY (network_id) REFERENCES network(id) ON DELETE CASCADE, > When removing a labeled network/detaching it from a cluster, we are trying if we want to play it safe, then there has to be no assumptions and no need for documentation. why's RemoveNetworkCommand removing network as a first action? Wouldn't it solve the problem if network is detached first and then removed? Line 17: FOREIGN KEY (nic_id) REFERENCES vds_interface(id) ON DELETE SET NULL Line 18: ); Line 19: Line 20: CREATE INDEX IDX_network_attachments_nic_id ON network_attachments(nic_id); -- To view, visit https://gerrit.ovirt.org/32581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84187f3900b9e3f8a917fc4e4126de9e50e231b4 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
