Martin Mucha has posted comments on this change. Change subject: engine: Add NetworkAttachment dao ......................................................................
Patch Set 19: (2 comments) https://gerrit.ovirt.org/#/c/32581/19/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDaoTest.java: Line 53: NetworkAttachment result = dao.get(FixturesTool.NETWORK_ATTACHMENT); Line 54: Line 55: assertNotNull(result); Line 56: assertEquals(FixturesTool.NETWORK_ATTACHMENT, result.getId()); Line 57: assertEquals(NetworkBootProtocol.DHCP, result.getIpConfiguration().getBootProtocol()); > The new method is ok. Done Line 58: } Line 59: Line 60: /** Line 61: * Ensures that network attachments are returned. https://gerrit.ovirt.org/#/c/32581/19/packaging/dbscripts/upgrade/03_06_1170_add_network_attachment.sql File packaging/dbscripts/upgrade/03_06_1170_add_network_attachment.sql: Line 13: custom_properties TEXT, Line 14: _create_date TIMESTAMP WITH TIME ZONE DEFAULT ('now'::text)::timestamp without time zone, Line 15: _update_date TIMESTAMP WITH TIME ZONE, Line 16: FOREIGN KEY (network_id) REFERENCES network(id) ON DELETE CASCADE, Line 17: FOREIGN KEY (nic_id) REFERENCES vds_interface(id) ON DELETE SET NULL > The user have no action for deleting the host interfaces. It is done via th Done Line 18: ); Line 19: Line 20: CREATE INDEX IDX_network_attachments_nic_id ON network_attachments(nic_id); Line 21: -- To view, visit https://gerrit.ovirt.org/32581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84187f3900b9e3f8a917fc4e4126de9e50e231b4 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
