Yair Zaslavsky has posted comments on this change.
Change subject: Adding bios information to vds object
......................................................................
Patch Set 9: (3 inline comments)
I still prefer you use java camel case notations for fields and getters/setters.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
Line 306: boolean returnValue = true;
Line 307: VdsStatic vds = new
VdsStatic(getParameters().getVdsHostName(), "",
Line 308: getStrippedVdsUniqueId(),
getParameters().getPort(), vdsGroupId, Guid.Empty,
Line 309: getParameters().getVdsName(), Config.<Boolean>
GetValue(ConfigValues.SSLEnabled),
Line 310: getParameters().getVdsType(), "N/A", "N/A",
"N/A", "N/A", "N/A", "N/A"); // management
Maybe have N/A as constant? :) not mandatory,but still...
Line 311:
// ip
Line 312:
// not
Line 313:
// currently
Line 314:
// passed
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java
Line 167: }
Line 168:
Line 169: public VdsDynamic(Integer cpu_cores,
Line 170: String cpu_model, Double cpu_speed_mh, String
if_total_speed,
Line 171: Boolean kvm_enabled, Integer mem_commited, Integer
physical_mem_mb, int status, Guid vds_id,
I suspect there is no real change here, as you modified VdsStatic.
If I am right - please make sure next round of patch does not include this file.
Line 172: Integer vm_active, int vm_count, Integer vm_migrating,
Integer reserved_mem, Integer guest_overhead,
Line 173: VDSStatus previous_status, String software_version,
String version_name, String build_name,
Line 174: Date cpu_over_commit_time_stamp, Integer
pending_vcpus_count,
Line 175: Integer pending_vmem_sizeField, Boolean net_config_dirty)
{
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
Line 360: }
Line 361:
Line 362:
Line 363: public String gethost_uuid() {
Line 364: return this.host_uuid;
Why not java Camel Case notation? :(
I would prefer getHostUuid.
Line 365: }
Line 366:
Line 367: public String gethost_family() {
Line 368: return this.host_family;
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
