Michael Kublin has posted comments on this change.
Change subject: Adding bios information to vds object
......................................................................
Patch Set 11: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 69:
Line 70: if (vdsGroup.supportsGlusterService()) {
Line 71: setSucceeded(initGlusterPeerProcess());
Line 72: }
Line 73:
should be triggered only if we success.
Also if it will fail a host will be moved to NonOperational if these is not
intention , add a try catch, if it is add appropriate failure reason of failure
to AuditLog
Line 74: runVdsCommand(VDSCommandType.GetBiosInfo, new
VdsIdAndVdsVDSCommandParametersBase(getVds()));
Line 75: }
Line 76:
Line 77: private boolean initVirtResources() {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetBiosInfoVDSCommand.java
Line 7:
Line 8: @Logged(executionLevel = LogLevel.DEBUG)
Line 9: public class GetBiosInfoVDSCommand<P extends
VdsIdAndVdsVDSCommandParametersBase> extends InfoVdsBrokerCommand<P> {
Line 10: public GetBiosInfoVDSCommand(P parameters) {
Line 11: super(parameters, parameters.getVds());
Remove these code is useless , you usually pass a vdsm
Line 12: if (getVds() == null) {
Line 13:
setVds(DbFacade.getInstance().getVdsDao().get(parameters.getVdsId()));
Line 14: parameters.setVds(getVds());
Line 15: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
Line 463: vds.sethost_product_name(AssignStringValue(biosInfo,
VdsProperties.host_product_name));
Line 464: vds.sethost_version(AssignStringValue(biosInfo,
VdsProperties.host_version));
Line 465: vds.sethost_serial_number(AssignStringValue(biosInfo,
VdsProperties.host_serial_number));
Line 466: vds.sethost_uuid(AssignStringValue(biosInfo,
VdsProperties.host_uuid));
Line 467: vds.sethost_family(AssignStringValue(biosInfo,
VdsProperties.host_family));
remove from here an update of DB, the following method should only convert info
retrieved from host
Line 468:
DbFacade.getInstance().getVdsStaticDao().update(vds.getStaticData());
Line 469: }
Line 470:
Line 471: private static String GetPackageVersionFormated(XmlRpcStruct
hostPackage, boolean getName) {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 357: /**
Line 358: * Save static data to cache and DB.
Line 359: *
Line 360: * @param staticData
Line 361: */
Why these method is here?
Line 362: public void UpdateStaticData(VdsStatic staticData) {
Line 363: DbFacade.getInstance().getVdsStaticDao().update(staticData);
Line 364: }
Line 365:
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
