Maor Lipchuk has posted comments on this change.
Change subject: Adding bios information to vds object
......................................................................
Patch Set 12: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
Line 357: public void setSSHKeyFingerprint(String sshKeyFingerprint) {
Line 358: this.sshKeyFingerprint = sshKeyFingerprint;
Line 359: }
Line 360:
Line 361:
Consider to order get and set of the same attribute together as we do in other
attributes
Line 362: public String getBiosUUID() {
Line 363: return this.biosUUID;
Line 364: }
Line 365:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 360: * Save static data to cache and DB if changed.
Line 361: *
Line 362: * @param current static data and old vds data
Line 363: */
Line 364: public void UpdateStaticData(VdsStatic staticData, VdsStatic
vdsOldStaticData) {
/s/UpdateStaticData/updateStaticData
Line 365: if (!staticData.equals(vdsOldStaticData)){
Line 366:
DbFacade.getInstance().getVdsStaticDao().update(staticData);
Line 367: }
Line 368: }
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
