Juan Hernandez has posted comments on this change.
Change subject: Shell-In-A-Box UI plugin - adding RPM spec file
......................................................................
Patch Set 3: Verified; Looks good to me, but someone else must approve
As this is an example I think it is good enough to merge, and I built and
installed it successfully.
However, if you want to make a package that can eventually be submitted to be
included in a distribution like Fedora I would suggest the following changes:
In the release tag ad the "dist" suffix:
Release: 1%{?dist}
Add the url tag:
Url: http://www.ovirt.org
Add instructions on how to create the tarball:
#
# To create the tarball execute the following commands:
#
# git clone git://gerrit.ovirt.org/samples-uiplugins
# cd samples-uiplugins/shellbox-plugin
# git archive --prefix=ovirt-engine-shellinabox-uiplugin-0.1
--output=ovirt-engine-shellinabox-uiplugin-0.1.tar HEAD .
#
Source: %{name}-%{version}.tar
Add the requirement of ovirt-engine (as I said in another comment I think it
should require 3.3.0 at least):
Requires: ovirt-engine-backend >= X.Y.Z
Create an empty %build section (this is just to make rpmlint happy):
%build
# Empty on purpose, nothing to build.
I am also curious why the license is GPL instead of ASL like ovirt-engine.
--
To view, visit http://gerrit.ovirt.org/11198
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If916c7cf022e9e903cd06e55f7b8ff34851ab9c8
Gerrit-PatchSet: 3
Gerrit-Project: samples-uiplugins
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
