Juan Hernandez has posted comments on this change.
Change subject: Shell-In-A-Box UI plugin - adding RPM spec file
......................................................................
Patch Set 2: (1 inline comment)
Looks good, thanks Daniel, only one small comment about the changelog.
....................................................
File shellbox-plugin/ovirt-engine-shellinabox-uiplugin.spec
Line 27: %{pluginspath}/shellbox.json
Line 28: %{pluginspath}/shellbox-files/start.html
Line 29:
Line 30: %changelog
Line 31: * Fri Jan 8 2013 Daniel Erez <[email protected]> - %{version}-%{release}
I have never seen %{version} or %{release} used in the changelog in this way.
It may work, but what happens when you release next version and add a new
changelog message? You will have to amend the previous message to put the old
version. I would suggest to use the version and release numbers directly.
--
To view, visit http://gerrit.ovirt.org/11198
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If916c7cf022e9e903cd06e55f7b8ff34851ab9c8
Gerrit-PatchSet: 2
Gerrit-Project: samples-uiplugins
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
