Vered Volansky has posted comments on this change.
Change subject: core: improve logs in VdsManager
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 368: try {
Line 369: // refresh vds from db in case changed while was down
Line 370: if (log.isDebugEnabled()) {
Line 371: log.debugFormat(
Line 372: "Trying to activate host {0} , meanwhile
setting status to Unassigned meanwhile",
remove last redundant meanwhile
Line 373: getVdsId());
Line 374: }
Line 375: vds = DbFacade.getInstance().getVdsDao().get(getVdsId());
Line 376: /**
Line 536:
Line 537: if (isSetNonOperational && returnStatus !=
VDSStatus.NonOperational) {
Line 538: if (log.isDebugEnabled()) {
Line 539: log.debugFormat(
Line 540:
"refreshCapabilities:GetCapabilitiesVDSCommand vds {0} networks do not match
its cluster networks, vds will be moved to NonOperational",
Any reason to leave refreshCapabilities in the beginning? And why only one
colon when hereafter you use two?
Line 541: vds.getStaticData().getId());
Line 542: }
Line 543: vds.setstatus(VDSStatus.NonOperational);
Line 544:
vds.setNonOperationalReason(NonOperationalReason.NETWORK_UNREACHABLE);
Line 600: return true;
Line 601: }
Line 602: setStatus(VDSStatus.NonResponsive, vds);
Line 603: log.errorFormat(
Line 604: "VDS::handleNetworkException Server failed to
respond, vds_id = {0}, vds_name = {1}, error = {2}",
The same as before with VDS
Line 605: vds.getId(), vds.getvds_name(), ex.getMessage());
Line 606:
Line 607: AuditLogableBase logable = new
AuditLogableBase(vds.getId());
Line 608: AuditLogDirector.log(logable, AuditLogType.VDS_FAILURE);
--
To view, visit http://gerrit.ovirt.org/11270
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I815f0c7bdadc25be5fa3f0829114f1d7f2a2dddd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
