Roy Golan has posted comments on this change.
Change subject: core: improve logs in VdsManager
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 124:
Line 125: private final Guid _vdsId;
Line 126:
Line 127: private VdsManager(VDS vds) {
Line 128: log.info("Entered VdsManager constructor");
since the InitVdsBroker is logged I don't see a good reason logging the
constructor.
Line 129: _vds = vds;
Line 130: _vdsId = vds.getId();
Line 131: monitoringStrategy =
MonitoringStrategyFactory.getMonitoringStrategyForVds(vds);
Line 132: mUnrespondedAttempts = new AtomicInteger();
Line 366: public void activate() {
Line 367: VDS vds = null;
Line 368: try {
Line 369: // refresh vds from db in case changed while was down
Line 370: if (log.isDebugEnabled()) {
^ can you remove this redundant check as well?
Line 371: log.debugFormat(
Line 372: "Trying to activate host {0} , meanwhile
setting status to Unassigned meanwhile",
Line 373: getVdsId());
Line 374: }
Line 386: } catch (java.lang.Exception e) {
Line 387: log.infoFormat("Failed to get VDS = {0} capabilities with
error: {1}.",
Line 388: getVdsId(), e.getMessage());
Line 389: log.infoFormat("Failed to activate VDS = {0}",
getVdsId());
Line 390:
a bit confusing to have 2 records here. Can you rephrase and have them merged
to a single message?
Line 391: } finally {
Line 392: if (vds != null) {
Line 393: UpdateDynamicData(vds.getDynamicData());
Line 394:
--
To view, visit http://gerrit.ovirt.org/11270
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I815f0c7bdadc25be5fa3f0829114f1d7f2a2dddd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
