Alissa Bonas has posted comments on this change.
Change subject: core: improve logs in VdsManager
......................................................................
Patch Set 1: (6 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 124:
Line 125: private final Guid _vdsId;
Line 126:
Line 127: private VdsManager(VDS vds) {
Line 128: log.info("Entered VdsManager constructor");
the logging was here before my change as well, I just fixed its mispelling and
replaced it to be not in the middle of ctor.
Line 129: _vds = vds;
Line 130: _vdsId = vds.getId();
Line 131: monitoringStrategy =
MonitoringStrategyFactory.getMonitoringStrategyForVds(vds);
Line 132: mUnrespondedAttempts = new AtomicInteger();
Line 366: public void activate() {
Line 367: VDS vds = null;
Line 368: try {
Line 369: // refresh vds from db in case changed while was down
Line 370: if (log.isDebugEnabled()) {
Done
Line 371: log.debugFormat(
Line 372: "Trying to activate host {0} , meanwhile
setting status to Unassigned meanwhile",
Line 373: getVdsId());
Line 374: }
Line 368: try {
Line 369: // refresh vds from db in case changed while was down
Line 370: if (log.isDebugEnabled()) {
Line 371: log.debugFormat(
Line 372: "Trying to activate host {0} , meanwhile
setting status to Unassigned meanwhile",
Done
Line 373: getVdsId());
Line 374: }
Line 375: vds = DbFacade.getInstance().getVdsDao().get(getVdsId());
Line 376: /**
Line 386: } catch (java.lang.Exception e) {
Line 387: log.infoFormat("Failed to get VDS = {0} capabilities with
error: {1}.",
Line 388: getVdsId(), e.getMessage());
Line 389: log.infoFormat("Failed to activate VDS = {0}",
getVdsId());
Line 390:
Done
Line 391: } finally {
Line 392: if (vds != null) {
Line 393: UpdateDynamicData(vds.getDynamicData());
Line 394:
Line 536:
Line 537: if (isSetNonOperational && returnStatus !=
VDSStatus.NonOperational) {
Line 538: if (log.isDebugEnabled()) {
Line 539: log.debugFormat(
Line 540:
"refreshCapabilities:GetCapabilitiesVDSCommand vds {0} networks do not match
its cluster networks, vds will be moved to NonOperational",
Done
Line 541: vds.getStaticData().getId());
Line 542: }
Line 543: vds.setstatus(VDSStatus.NonOperational);
Line 544:
vds.setNonOperationalReason(NonOperationalReason.NETWORK_UNREACHABLE);
Line 600: return true;
Line 601: }
Line 602: setStatus(VDSStatus.NonResponsive, vds);
Line 603: log.errorFormat(
Line 604: "VDS::handleNetworkException Server failed to
respond, vds_id = {0}, vds_name = {1}, error = {2}",
Done
Line 605: vds.getId(), vds.getvds_name(), ex.getMessage());
Line 606:
Line 607: AuditLogableBase logable = new
AuditLogableBase(vds.getId());
Line 608: AuditLogDirector.log(logable, AuditLogType.VDS_FAILURE);
--
To view, visit http://gerrit.ovirt.org/11270
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I815f0c7bdadc25be5fa3f0829114f1d7f2a2dddd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
