Vered Volansky has posted comments on this change. Change subject: core: Standardize RemoveSnapshot.canDoAction ......................................................................
Patch Set 1: There was no test for these parameters before, but I think you should add one to make sure it's entered when you think it does. The flow isn't the same as when it comes from within canDoAction from my previous experience with this issue. -- To view, visit http://gerrit.ovirt.org/11322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93f391984827fa5deb816d8856a982bf03b77df1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
