Tal Nisan has posted comments on this change.
Change subject: core: Standardize RemoveSnapshot.canDoAction
......................................................................
Patch Set 2: Looks good to me, approved
This change fits the command standard, the type and the action should be set in
the setActionMessageParameters() otherwise it may cause some early returns in
canDo phase messages to look as Cannot ${Type} ${Action}
--
To view, visit http://gerrit.ovirt.org/11322
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93f391984827fa5deb816d8856a982bf03b77df1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
