Vered Volansky has posted comments on this change. Change subject: core: Standardize RemoveSnapshot.canDoAction ......................................................................
Patch Set 2: Allon, I think verifying any of the error messages do have those parameters is fine. I'd say they all should have been checked since this could have affected them all, but that would be too excessive. I'd just go with the fail messages you touched in this file and that's it. -- To view, visit http://gerrit.ovirt.org/11322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93f391984827fa5deb816d8856a982bf03b77df1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
