Allon Mureinik has uploaded a new change for review. Change subject: core: Mae IVdcUser extend Serializable ......................................................................
core: Mae IVdcUser extend Serializable Define IVdcUser as extends Serializeable so Serializable classes code inspection (such as FindBugs) applied to classes containing it do not fret about a Serializable class with a non Serializable member. Note that this does not change the current behaviour, as VdcUser, the only known implementation of IVdcUser in fact implements Seriazlizable. To be on the safe side, since some frameworks look for the explicit definition on the implementing class, its "implements Serializable" specification was left untouched, and the warning for needlessly specifying it was suppressed. Change-Id: Id02c1f62fe3406ee0bceaf75cb9d79ce034e4a4d Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/IVdcUser.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/05/11905/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/IVdcUser.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/IVdcUser.java index ab40822..a656813 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/IVdcUser.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/IVdcUser.java @@ -1,8 +1,10 @@ package org.ovirt.engine.core.common.interfaces; +import java.io.Serializable; + import org.ovirt.engine.core.compat.Guid; -public interface IVdcUser { +public interface IVdcUser extends Serializable { String getPassword(); void setPassword(String value); diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java index a57a676..097f37a 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java @@ -6,6 +6,7 @@ import org.ovirt.engine.core.common.interfaces.IVdcUser; import org.ovirt.engine.core.compat.Guid; +@SuppressWarnings("unused") public class VdcUser implements IVdcUser, Serializable { private static final long serialVersionUID = -5689096270467866486L; @@ -17,10 +18,12 @@ private String mGroupNames; private String groupIds; + @Override public String getGroupIds() { return groupIds; } + @Override public void setGroupIds(String groupIds) { this.groupIds = groupIds; } -- To view, visit http://gerrit.ovirt.org/11905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id02c1f62fe3406ee0bceaf75cb9d79ce034e4a4d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
