Michael Kublin has posted comments on this change.
Change subject: core: Mae IVdcUser extend Serializable
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java
Line 6: import org.ovirt.engine.core.common.interfaces.IVdcUser;
Line 7: import org.ovirt.engine.core.compat.Guid;
Line 8:
Line 9: @SuppressWarnings("unused")
Line 10: public class VdcUser implements IVdcUser, Serializable {
why not remove serializable here?
Line 11: private static final long serialVersionUID = -5689096270467866486L;
Line 12:
Line 13: private Guid mUserId = new Guid();
Line 14: private String mUserName;
....................................................
Commit Message
Line 3: AuthorDate: 2013-02-10 20:05:34 +0200
Line 4: Commit: Allon Mureinik <[email protected]>
Line 5: CommitDate: 2013-02-11 10:13:21 +0200
Line 6:
Line 7: core: Mae IVdcUser extend Serializable
make
Line 8:
Line 9: Define IVdcUser as extends Serializeable so Serializable classes
Line 10: code inspection (such as FindBugs) applied to classes containing it do
Line 11: not fret about a Serializable class with a non Serializable member.
--
To view, visit http://gerrit.ovirt.org/11905
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id02c1f62fe3406ee0bceaf75cb9d79ce034e4a4d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
