Allon Mureinik has posted comments on this change. Change subject: core: Mae IVdcUser extend Serializable ......................................................................
Patch Set 1: (1 inline comment) @Michael - I think I did not explain the issue correctly. E.g., look at AuditLogableBase - it is serializable since it extends TimeoutBase, which implements serializable. It also has a member mVdcUser, of type IVdcUser. Serializable class + non-serializable member = fail. This patch will fix this issue, but if you have a better solution I'd appreciate the advise. .................................................... Commit Message Line 3: AuthorDate: 2013-02-10 20:05:34 +0200 Line 4: Commit: Allon Mureinik <[email protected]> Line 5: CommitDate: 2013-02-11 10:13:21 +0200 Line 6: Line 7: core: Mae IVdcUser extend Serializable Thanks, will fix. Line 8: Line 9: Define IVdcUser as extends Serializeable so Serializable classes Line 10: code inspection (such as FindBugs) applied to classes containing it do Line 11: not fret about a Serializable class with a non Serializable member. -- To view, visit http://gerrit.ovirt.org/11905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id02c1f62fe3406ee0bceaf75cb9d79ce034e4a4d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
