Eli Mesika has posted comments on this change. Change subject: engine: Manage Gluster hooks support ......................................................................
Patch Set 20: (3 inline comments) .................................................... File backend/manager/dbscripts/gluster_hooks_sp.sql Line 27: Line 28: Line 29: Line 30: Create or replace FUNCTION GetGlusterHookById(v_id UUID, Line 31: v_returnAll BOOLEAN=false) agree, this contradict the standard Line 32: RETURNS SETOF gluster_hooks Line 33: AS $procedure$ Line 34: BEGIN Line 35: if (v_returnAll = true) then Line 74: Create or replace FUNCTION GetGlusterHook(v_cluster_id UUID, Line 75: v_gluster_command VARCHAR(1000), Line 76: v_stage VARCHAR(100), Line 77: v_name VARCHAR(1000), Line 78: v_returnAll BOOLEAN=false) agree, this contradict the standard Line 79: RETURNS SETOF gluster_hooks Line 80: AS $procedure$ Line 81: BEGIN Line 82: if (v_returnAll = true) then Line 119: END; $procedure$ Line 120: LANGUAGE plpgsql; Line 121: Line 122: Line 123: Create or replace FUNCTION DeleteGlusterHooksByIds(v_ids VARCHAR(5000)) why not simply use a text variable Line 124: RETURNS VOID Line 125: AS $procedure$ Line 126: BEGIN Line 127: DELETE FROM gluster_hooks -- To view, visit http://gerrit.ovirt.org/10650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8b2d261ead720fccea6884acbc806ec79e52b36 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Selvasundaram <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
