Shireesh Anjal has posted comments on this change. Change subject: engine: Manage Gluster hooks support ......................................................................
Patch Set 21: Looks good to me, but someone else must approve (4 inline comments) Apart from the trailing whitespaces in gluster_hooks_sp.sql, Looks good to me. .................................................... File backend/manager/dbscripts/gluster_hooks_sp.sql Line 261: UPDATE gluster_server_hooks Line 262: SET hook_status = v_hook_status, Line 263: _update_date = LOCALTIMESTAMP Line 264: WHERE hook_id = v_hook_id AND server_id = v_server_id; Line 265: Please remove trailing whitespace Line 266: UPDATE gluster_hooks Line 267: SET _update_date = LOCALTIMESTAMP Line 268: WHERE id = v_hook_id; Line 269: Line 265: Line 266: UPDATE gluster_hooks Line 267: SET _update_date = LOCALTIMESTAMP Line 268: WHERE id = v_hook_id; Line 269: Please remove trailing whitespace Line 270: END; $procedure$ Line 271: LANGUAGE plpgsql; Line 272: Line 273: Line 302: AS $procedure$ Line 303: BEGIN Line 304: DELETE FROM gluster_server_hooks Line 305: WHERE hook_id in (select * from fnSplitterUuid(v_ids)); Line 306: Please remove trailing whitespace Line 307: UPDATE gluster_hooks Line 308: SET _update_date = LOCALTIMESTAMP Line 309: WHERE id in (select * from fnSplitterUuid(v_ids)); Line 310: END; $procedure$ Line 317: AS $procedure$ Line 318: BEGIN Line 319: DELETE FROM gluster_server_hooks Line 320: WHERE hook_id = v_hook_id AND server_id = v_server_id; Line 321: Please remove trailing whitespace Line 322: UPDATE gluster_hooks Line 323: SET _update_date = LOCALTIMESTAMP Line 324: WHERE id = v_hook_id; Line 325: END; $procedure$ -- To view, visit http://gerrit.ovirt.org/10650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8b2d261ead720fccea6884acbc806ec79e52b36 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Selvasundaram <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
