Shireesh Anjal has posted comments on this change. Change subject: engine: Manage Gluster hooks support ......................................................................
Patch Set 22: (1 inline comment) .................................................... File backend/manager/dbscripts/gluster_hooks_sp.sql Line 27: Line 28: Line 29: Line 30: Create or replace FUNCTION GetGlusterHookById(v_id UUID, Line 31: v_includeContent BOOLEAN=false) I agree with Sahina. I don't think we should create views when there is a single table involved. Conditionally fetching actual value or null for the text column is good enough. Line 32: RETURNS SETOF gluster_hooks Line 33: AS $procedure$ Line 34: BEGIN Line 35: if (v_includeContent = true) then -- To view, visit http://gerrit.ovirt.org/10650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8b2d261ead720fccea6884acbc806ec79e52b36 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Selvasundaram <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
