Federico Simoncelli has posted comments on this change.
Change subject: core: add the image block alignment scan
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java
Line 185: alignment = value;
Line 186: }
Line 187:
Line 188: public Date getLastAlignmentScan() {
Line 189: return (Date) lastAlignmentScan.clone();
Possible NullPointerException. Any objection to:
return (lastAlignmentScan != null) ? (Date) lastAlignmentScan.clone() : null;
Line 190: }
Line 191:
Line 192: public void setLastAlignmentScan(Date value) {
Line 193: lastAlignmentScan = (Date) value.clone();
Line 189: return (Date) lastAlignmentScan.clone();
Line 190: }
Line 191:
Line 192: public void setLastAlignmentScan(Date value) {
Line 193: lastAlignmentScan = (Date) value.clone();
Possible NullPointerException. Any objection to:
lastAlignmentScan = (value != null) ? (Date) value.clone() : null;
Line 194: }
Line 195:
Line 196: @Override
Line 197: public int hashCode() {
--
To view, visit http://gerrit.ovirt.org/11946
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4858b7bbfa453230fcafecfbc5358c715d5d825b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
