Liron Ar has posted comments on this change.
Change subject: core: add the image block alignment scan
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ScanDiskAlignmentCommand.java
Line 65:
Line 66: @Override
Line 67: protected Map<String, Pair<String, String>> getSharedLocks() {
Line 68: if (getDisk() != null && !isImageExclusiveLockNeeded()) {
Line 69: return
Collections.singletonMap(getDisk().getId().toString(),
LockMessagesMatchUtil.DISK);
It does with general message, i thought about specific message to this case.
Line 70: }
Line 71: return null;
Line 72: }
Line 73:
Line 216: }
Line 217:
Line 218: protected Guid getVdsIdInPool() {
Line 219: if (vdsInPool == null && getStoragePoolId() != null) {
Line 220: for (VDS vds : getVdsDAO().getAllForStoragePoolAndStatus(
just take the first one if the list isn't empty
Line 221: getStoragePoolId(), VDSStatus.Up)) {
Line 222: vdsInPool = vds.getId();
Line 223: break; // At the moment we select the first VDS in Up
status
Line 224: }
--
To view, visit http://gerrit.ovirt.org/11946
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4858b7bbfa453230fcafecfbc5358c715d5d825b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
