Alissa Bonas has posted comments on this change.
Change subject: core: add the image block alignment scan
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskAlignment.java
Line 28: public int getValue() {
Line 29: return intValue;
Line 30: }
Line 31:
Line 32: public static DiskAlignment forValue(int value) {
It doesn't mean it's a good example that it exists in the engine :)
And I don't see any need to follow a non standard practice which is also
unclear.
Line 33: return mappings.get(value);
Line 34: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AlignmentScanReturnForXmlRpc.java
Line 4:
Line 5: import org.ovirt.engine.core.vdsbroker.irsbroker.StatusReturnForXmlRpc;
Line 6:
Line 7: public final class AlignmentScanReturnForXmlRpc extends
StatusReturnForXmlRpc {
Line 8: private static final String ALIGNMENT = "alignment";
IMHO there is no need to stick with something that is not good.
Line 9:
Line 10: private Map<String, Object> mAlignment;
Line 11:
Line 12: public AlignmentScanReturnForXmlRpc(Map<String, Object> innerMap) {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ScanDiskAlignmentVDSCommand.java
Line 2:
Line 3: import
org.ovirt.engine.core.common.vdscommands.ScanDiskAlignmentVDSCommandParameters;
Line 4:
Line 5: public class ScanDiskAlignmentVDSCommand<P extends
ScanDiskAlignmentVDSCommandParameters> extends VdsBrokerCommand<P> {
Line 6: private AlignmentScanReturnForXmlRpc mDiskAlignment;
I agree, it should be a good cleanup. consider adding it to hackaton list?
Line 7:
Line 8: public ScanDiskAlignmentVDSCommand(P parameters) {
Line 9: super(parameters);
Line 10: }
--
To view, visit http://gerrit.ovirt.org/11946
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4858b7bbfa453230fcafecfbc5358c715d5d825b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
