Sahina Bose has posted comments on this change.
Change subject: engine: improved getVdsId and getGlusterVolumeId
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/gluster/GlusterAuditLogUtil.java
Line 38: public void logAuditMessage(final Guid clusterId,
Line 39: final GlusterVolumeEntity volume,
Line 40: final VDS server,
Line 41: final AuditLogType logType,
Line 42: final Map<String, String> customValues) {
Just a thought - would it be better to create an instance of AuditLogableBase
and call setters on them, instead of overriding getters?
Line 43: AuditLogDirector.log(new AuditLogableBase() {
Line 44: @Override
Line 45: protected VDS getVds() {
Line 46: return server;
--
To view, visit http://gerrit.ovirt.org/13001
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52212ddb694d727248182d32abc1e1f5a21f76ee
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
