Omer Frenkel has posted comments on this change.
Change subject: gluster: improved gluster audit log util
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
Line 218:
Line 219: public Guid getVdsId() {
Line 220: if (mVdsId != null) {
Line 221: return mVdsId.getValue();
Line 222: } else if (getVds() != null) {
although this looks like a good change it might be risky,
getVds() can call getVdsId() as well and it doesnt look right, also its hard to
know what flows in the code might be affected from this change, is it really
necessary?
Line 223: mVdsId = getVds().getId();
Line 224: return mVdsId.getValue();
Line 225: } else {
Line 226: return Guid.Empty;
--
To view, visit http://gerrit.ovirt.org/13001
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52212ddb694d727248182d32abc1e1f5a21f76ee
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
