Yair Zaslavsky has posted comments on this change.
Change subject: gluster: improved gluster audit log util
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
Line 320: public AuditLogType getAuditLogTypeValue() {
Line 321: return logType == null ? AuditLogType.UNASSIGNED : logType;
Line 322: }
Line 323:
Line 324: public void setAuditLogType(AuditLogType logType) {
No need. See my other comment.
Line 325: this.logType = logType;
Line 326: }
Line 327:
Line 328: protected VDS getVds() {
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/gluster/GlusterAuditLogUtil.java
Line 50: logable.addCustomValue(key, customValues.get(key));
Line 51: }
Line 52: }
Line 53:
Line 54: AuditLogDirector.log(logable);
HI,
Why not use the log method that accepts (logable,logType) ?
See LdapBrokerUtils.logEventForUser
Line 55: }
--
To view, visit http://gerrit.ovirt.org/13001
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52212ddb694d727248182d32abc1e1f5a21f76ee
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
