Doron Fediuck has posted comments on this change.
Change subject: webadmin: fixing edit policy button style
......................................................................
Patch Set 1: (1 inline comment)
I have a concern that leaving it unlimited may go wild.
See inline some proposals.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.ui.xml
Line 8: <ui:with field='constants'
type='org.ovirt.engine.ui.webadmin.ApplicationConstants' />
Line 9:
Line 10: <ui:style>
Line 11: .button {
Line 12: margin: 10px 0px;
This may end up as a very width and ugly control in another language.
1. Is there a way to do text.width (or is current implementation good enough)?
2. can we limit it to XXX (should be big enough) and beyond that cut it with
'...' and have a tooltip with the full name? So the button will look like:
Prevent-
[ Very-long-button-name-in-some-other-language ]
By-
[ Very-long-button-name... ]
Line 13: }
Line 14: .transparent {
Line 15: width: 400px;
Line 16: height: 40px;
--
To view, visit http://gerrit.ovirt.org/13194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe84279c19fb9b8824acc8fb3d082c131f5083c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
