Einav Cohen has posted comments on this change.

Change subject: webadmin: fixing edit policy button style
......................................................................


Patch Set 1:

[take #2, hopefully with the correct bulletting this time]

- see my inline comments

- I am actually not sure why the button style is not consistent with all of the 
other main-tabs/sub-tabs buttons. Maybe worth considering doing something more 
like http://oi46.tinypic.com/vos7b7.jpg - what do you think? [can be done in a 
separate patch, of course - not urgent]

- patch doesn't rebase cleanly, since it changes a CSS style that has been 
removed in http://gerrit.ovirt.org/#/c/12945 (merged), so even if we are not 
implementing the suggestion in the previous bullet - need to send an updated 
patch anyway.

Thanks.

--
To view, visit http://gerrit.ovirt.org/13194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe84279c19fb9b8824acc8fb3d082c131f5083c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to