Einav Cohen has posted comments on this change. Change subject: webadmin: fixing edit policy button style ......................................................................
Patch Set 1: (2 inline comments) - see my inline comments - I am actually not sure why the button style is not consistent with all of the other main-tabs/sub-tabs buttons. Maybe worth considering doing something more like http://oi46.tinypic.com/vos7b7.jpg - what do you think? [can be done in a separate patch, of course - not urgent] - patch doesn't rebase cleanly, since it changes a CSS style that has been removed in http://gerrit.ovirt.org/#/c/12945 (merged), so even if we are not implementing the suggestion in the previous bullet - need to send an updated patch anyway. Thanks. .................................................... Commit Message Line 5: CommitDate: 2013-03-20 11:12:02 +0200 Line 6: Line 7: webadmin: fixing edit policy button style Line 8: Line 9: In other lacales the button text overflow. - typo (lacales -> locales) - see my inline comment for SubTabClusterGeneralView.ui.xml - problem is not with "button text overflow"; the text is OK, the borders are simply truncated. Line 10: Fixed alignment (margin) and removed button's width. Line 11: Line 12: Change-Id: Ibfe84279c19fb9b8824acc8fb3d082c131f5083c Line 13: Bug-Url: https://bugzilla.redhat.com/921892 .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.ui.xml Line 8: <ui:with field='constants' type='org.ovirt.engine.ui.webadmin.ApplicationConstants' /> Line 9: Line 10: <ui:style> Line 11: .button { Line 12: margin: 10px 0px; "text.width" was pretty much the case even before this patch (see http://oi45.tinypic.com/w82i5z.jpg for screen-shots of the application before this patch has been applied - you can see that even before this patch, the Japanese button is "automatically" rendered as wider than the English button). IIUC, the problem documented in the BZ is not about *text* truncation/overflow - the Japanese "Edit Policy" text is fully shown within the button, without overflowing or truncating. The problem is about *borders* truncation of the button. [see http://oi47.tinypic.com/2igyhe8.jpg for the Edit Policy button in English, which properly has its borders displayed, vs. http://oi45.tinypic.com/awdmo.jpg (Edit Policy button in Japanese), which doesn't have its left and right borders displayed. Line 13: } Line 14: .transparent { Line 15: width: 400px; Line 16: height: 40px; -- To view, visit http://gerrit.ovirt.org/13194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfe84279c19fb9b8824acc8fb3d082c131f5083c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
