Maor Lipchuk has uploaded a new change for review. Change subject: core: Add log when task could not end action. ......................................................................
core: Add log when task could not end action. Adding a log when a task try to end an action but encounter a scenario that not all the tasks related to the entity were ended also. Without this log, it will be hard to realize that the entity has more tasks in it, if there was a bug that the tasks were not cleaned up properly. An example for this bug can be seen in the end of the log of the related bug BZ958061. The ended tasks are logged there over and over again but do not end the command properly. Change-Id: Ia1e4700676622b23c79a388b6aa3b92ae1aa15e9 Related-Bug: https://bugzilla.redhat.com/958061 Signed-off-by: Maor Lipchuk <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityMultiAsyncTasks.java 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/33/14433/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityMultiAsyncTasks.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityMultiAsyncTasks.java index 7706695..fe75372 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityMultiAsyncTasks.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityMultiAsyncTasks.java @@ -69,6 +69,10 @@ for (EntityAsyncTask task : CurrentActionTypeTasks) { if (task.getState() != AsyncTaskState.Ended) { + log.infoFormat("Task ID: '{0}' is in state {1}. End action for entity {2} will be procceeded when all the tasks will be in end state.", + task.getTaskID(), + task.getState(), + getContainerId()); return false; } } -- To view, visit http://gerrit.ovirt.org/14433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia1e4700676622b23c79a388b6aa3b92ae1aa15e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
