Yair Zaslavsky has posted comments on this change.
Change subject: core: Add log when task could not end action.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityMultiAsyncTasks.java
Line 68: java.util.ArrayList<EntityAsyncTask>
CurrentActionTypeTasks = GetCurrentActionTypeTasks();
Line 69:
Line 70: for (EntityAsyncTask task : CurrentActionTypeTasks) {
Line 71: if (task.getState() != AsyncTaskState.Ended) {
Line 72: log.infoFormat("Task ID: '{0}' is in state {1}.
End action for entity {2} will be procceeded when all the tasks will be in end
state.",
Vered - Good catch.
s/proceeded/processed
endAction is being handled only when all tasks for the entity were completed
(actually, the usage of the word "all" here is not 100% correct, but let's not
get into corner cases :) )
Line 73: task.getTaskID(),
Line 74: task.getState(),
Line 75: getContainerId());
Line 76: return false;
--
To view, visit http://gerrit.ovirt.org/14433
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1e4700676622b23c79a388b6aa3b92ae1aa15e9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
