Yair Zaslavsky has posted comments on this change. Change subject: core: Add log when task could not end action. ......................................................................
Patch Set 3: I would prefer that you didn't submit this I assume Maor intended to give clearer indication to when such situation occurs. The problem is (and Kublin is right here) is we have no indication when shouldEnd behaves properly (yes, we might have some tasks not in ended that belong to same command) and when it's not. -- To view, visit http://gerrit.ovirt.org/14433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1e4700676622b23c79a388b6aa3b92ae1aa15e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
