Alon Bar-Lev has posted comments on this change.
Change subject: engine: Allow engine to configure management network
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
Line 178: if (getVds().getStatus() == VDSStatus.Reboot) {
Line 179: if (configureNetwork) {
Line 180: RunSleepOnReboot();
Line 181: } else {
Line 182: ThreadPoolUtil.execute(new Runnable() {
I also don't think that status will be Reboot if reboot is skipped. You should
wait for vdsm to be active and then continue?
Line 183: @Override
Line 184: public void run() {
Line 185:
getBackend().runInternalAction(VdcActionType.ActivateVds,
Line 186: new
VdsActionParameters(getVds().getId()));
--
To view, visit http://gerrit.ovirt.org/14230
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf82e10481e595d690e7ce894283b4ed5b9b3269
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Martin Pavlik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
