Moti Asayag has posted comments on this change. Change subject: engine: Allow engine to configure management network ......................................................................
Patch Set 6: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java Line 28: import org.ovirt.engine.core.common.config.Config; Line 29: import org.ovirt.engine.core.common.config.ConfigValues; Line 30: import org.ovirt.engine.core.dal.dbbroker.DbFacade; Line 31: import org.ovirt.engine.core.utils.EngineLocalConfig; Line 32: import org.ovirt.engine.core.utils.NetworkUtils; This should break compilation due to checkstyle violation of unused import. In any case I intend to upload a new version of it soon. Line 33: import org.ovirt.engine.core.utils.archivers.tar.CachedTar; Line 34: import org.ovirt.engine.core.utils.crypt.OpenSSHUtils; Line 35: import org.ovirt.engine.core.utils.hostinstall.OpenSslCAWrapper; Line 36: import org.ovirt.engine.core.utils.linq.LinqUtils; -- To view, visit http://gerrit.ovirt.org/14230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf82e10481e595d690e7ce894283b4ed5b9b3269 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Martin Pavlik <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
