Alon Bar-Lev has posted comments on this change.

Change subject: engine: Allow engine to configure management network
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 418:                      VdsmEnv.MANAGEMENT_BRIDGE_NAME,
Line 419:                      _managementNetwork
Line 420:                  );
Line 421:              }
Line 422:              else if (_isNode) {
As long as ovirt-node creates the br* bridges, even in 3.3... the simplest 
solution is to force creation of the management bridge within the node, even if 
we were asked not to.
Line 423:                  _parser.cliEnvironmentSet(
Line 424:                      VdsmEnv.MANAGEMENT_BRIDGE_NAME,
Line 425:                      NetworkUtils.getEngineNetwork()
Line 426:                  );


--
To view, visit http://gerrit.ovirt.org/14230
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf82e10481e595d690e7ce894283b4ed5b9b3269
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Martin Pavlik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to