Alon Bar-Lev has posted comments on this change. Change subject: packaging: allow interactive NFS exports cleanup with engine-cleanup-2 ......................................................................
Patch Set 1: (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-remove/system/exportfs.py Line 97: osetupcons.ConfigEnv.PRESERVE_EXPORTS Line 98: ], Line 99: priority=plugin.Stages.PRIORITY_HIGH, Line 100: ) Line 101: def _add_nfs_export_to_unremovable(self): Can you please explain this function? why do we add this to unremovable? just to protect it? If so, better to have groups in setup and enable disable groups in remove. Line 102: config = configparser.ConfigParser() Line 103: config.optionxform = str Line 104: unremovable = [ Line 105: osetupcons.FileLocations.NFS_EXPORT_FILE -- To view, visit http://gerrit.ovirt.org/14702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16b5920f0cfc9f564aa92f7e0d5a6d33af5e0b44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
