Alon Bar-Lev has posted comments on this change.
Change subject: packaging: allow interactive NFS exports cleanup with
engine-cleanup-2
......................................................................
Patch Set 4: (3 inline comments)
OK, almost there, more suggestions...
....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 499: '-webadmin-portal',
Line 500: )
Line 501: ]
Line 502:
Line 503: UNINSTALL_GROUP_SECTION_PREFIX = 'uninstall_group_'
files_group_ ?
As it is obvious we doing uninstall :)
But... more importantally... we are going to add processing of files that are
not simple so we have strings_group_ or something similar as well (remove a
specific line from a file).
Line 504:
Line 505:
Line 506: @util.export
Line 507: @util.codegen
....................................................
File packaging/setup/plugins/ovirt-engine-remove/files/simple.py
Line 92
Line 93
Line 94
Line 95
Line 96
I think these 'files' should get into its own group, something like 'core', so
there will be no difference between processing of uninstall.
....................................................
File packaging/setup/plugins/ovirt-engine-setup/system/exportfs.py
Line 104: """
Line 105: uninstall_files = []
Line 106: self.environment[
Line 107: osetupcons.CoreEnv.UNINSTALL_GROUP_PREFIX + 'exportfs'
Line 108: ] = uninstall_files
As this is going to be commonly used, maybe have the uninstall plugin to
register a class within the environment so that only it knows the prefix?
Something like: self.environment[...UNINSTALL].addFiles(group, list)
This will be simple logic of the above.
Line 109: path = self.environment[
Line 110: osetupcons.ConfigEnv.ISO_DOMAIN_NFS_MOUNT_POINT
Line 111: ]
Line 112: content = '{path}\t0.0.0.0/0.0.0.0(rw)\n'.format(
--
To view, visit http://gerrit.ovirt.org/14702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16b5920f0cfc9f564aa92f7e0d5a6d33af5e0b44
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
