Alon Bar-Lev has posted comments on this change. Change subject: packaging: allow interactive NFS exports cleanup with engine-cleanup-2 ......................................................................
Patch Set 2: (1 inline comment) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 510: DEVELOPER_MODE = 'OVESETUP_CORE/developerMode' Line 511: UNINSTALL_UNREMOVABLE_FILES = 'OVESETUP_CORE/uninstallUnremovableFiles' Line 512: REMOVE = 'OVESETUP_CORE/remove' Line 513: UNINSTALL_PREFIX = 'OVESETUP_CORE_MODIFIED_FILE_GROUP/' Line 514: UNINSTALL_UNREMOVABLE_GROUPS = 'OVESETUP_CORE/unremovableGroups' Maybe better to have all groups disabled by default and explicit enable groups in the uninstall? Line 515: Line 516: Line 517: @util.export Line 518: @util.codegen -- To view, visit http://gerrit.ovirt.org/14702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16b5920f0cfc9f564aa92f7e0d5a6d33af5e0b44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
