Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: added FQDN validation to engine-setup-2
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/protocols.py
Line 96: pattern = (self._NS_REVLOOKUP_RE if reverse else
self._NS_LOOKUP_RE)
Line 97: addresses = set()
Line 98: rc, stdout, stderr = self.execute(
Line 99: args=(
Line 100: self.command.get('nslookup'),
I prefer dig over nslookup.
But I don't understand why do we want to avoid lookup in /etc/hosts... can you
please explain?
Line 101: addr,
Line 102: ),
Line 103: raiseOnError=False
Line 104: )
--
To view, visit http://gerrit.ovirt.org/14699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9764f32ba5e30062532bf11c67756677333c44f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
