Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: added FQDN validation to engine-setup-2
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/protocols.py
Line 159: args=args,
Line 160: raiseOnError=False
Line 161: )
Line 162: if rc == 0:
Line 163: #do not go over the first 2 lines in dig output
it's left over by previous implementation using nslookup, removing.
Line 164: for line in stdout[2:]:
Line 165: found = pattern.search(line)
Line 166: if found:
Line 167: foundAddress = found.group('answer')
--
To view, visit http://gerrit.ovirt.org/14699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9764f32ba5e30062532bf11c67756677333c44f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
