Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: added FQDN validation to engine-setup-2
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/protocols.py
Line 150:
Line 151: def _dig_lookup(self, addr, reverse=False):
Line 152: pattern = (self._DIG_REVLOOKUP_RE if reverse else
self._DIG_LOOKUP_RE)
Line 153: addresses = set()
Line 154: args = [self.command.get('dig')]
May I suggest 'dig +short'? Try it with different arguments to see what it does
in each case, but in any case it will simplify parsing a lot.
Line 155: if reverse:
Line 156: args.append('-x')
Line 157: args.append(addr)
Line 158: rc, stdout, stderr = self.execute(
--
To view, visit http://gerrit.ovirt.org/14699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9764f32ba5e30062532bf11c67756677333c44f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
