Shireesh Anjal has posted comments on this change. Change subject: engine: Improved duplicate host validation ......................................................................
Patch Set 1: Frankly I don't understand the objections. There is only one "resolve" - that of the server being added. Are the ip addresses of servers that are in "maintenance" mode not refreshed at all? If that is the case, then we can exclude the maintenance servers from the validation. The bug is very simple. Add a host using ip address, then add it again using host name (or vice versa). It should fail straightaway - not during the deploy phase. Allowing user to add such a host, and then move it to "install failed" (or something similar) is not user friendly at all! If anyone has a better way to do it, please suggest! -- To view, visit http://gerrit.ovirt.org/14402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37c5ee3546a21400678c2f1f7d1e54bb726988b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
