Alon Bar-Lev has posted comments on this change. Change subject: engine: Improved duplicate host validation ......................................................................
Patch Set 1: OK... another suggestion... We add a new utility to VDSM, or modify vdsclient to have new command. This new command will return vdsmid. We execute this at the early ssh session at the can do action, if vdsm is installed it will return its id, allowing us to fail early. Another option is to start the deployment process at the canDoAction, this will allow us to perform all the validation including the gluster peer, using host-deploy and not hacking it, and if validations are OK, we return to the user and continue the deployment at InstallVdsCommand's execute, actually merge these two commands. -- To view, visit http://gerrit.ovirt.org/14402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37c5ee3546a21400678c2f1f7d1e54bb726988b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
