Yaniv Bronhaim has posted comments on this change. Change subject: engine: Improved duplicate host validation ......................................................................
Patch Set 1: You prevent user from adding an host based on address instead of relying on the unique information that you have about the host, its UUID. Again, IP address is a dynamic information as all vds_interface table, that gets updated after getting capabilities from the host. This check can block the user from adding an host without meaning to. Lets say you add host with hostname "redhat.com" that resolved to 1.2.3.4, but old host "eng.redhat.com" is written already to DB with the address 1.2.3.4 (that not in use any more), the host is on maintenance or non-responsive for a while. In that case you'd fail the operation on address is already registered, but it doesn't mean that the host is installed already. Do you want to make it more complex and check only operational hosts? Why? InstallFailed is the right failure the user should receive if the host already installed, if the IP exists in cluster you can't assume that the host is registered.. What's wrong with failing the installation when distinguish duplication in host's UUID, and removing the host from the UI automatically after popup warning message? It happens quite fast after the deploy starts.. -- To view, visit http://gerrit.ovirt.org/14402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37c5ee3546a21400678c2f1f7d1e54bb726988b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
