Allon Mureinik has posted comments on this change.
Change subject: core: rename DiskImage method to a more clear name
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
Line 142: public long getActualSizeInBytes() {
Line 143: return actualSizeFromDiskImageDynamic;
Line 144: }
Line 145:
Line 146: public void setActualSizeFromDiskImage(long size) {
Please rename the setter and the datamember too
Line 147: actualSizeFromDiskImageDynamic = size;
Line 148: setActualSize(getActualSizeInBytes() * 1.0 / (1024 * 1024 *
1024));
Line 149: }
Line 150:
--
To view, visit http://gerrit.ovirt.org/14768
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf26bda8e00c1ae2f12b1decf6e1b4a8d12bed31
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
